address code review: POI order matches plan, self-documenting height reserve
Reorders the Verbrannte Straße POIs to plan §8's authored sequence (hunt, investigate, search, then the scout) — purely a keyboard tab-order fix, since hotspots are placed by percentage, not list order. Rewrites the location page's viewport-height reserve as a calc() over the same rem values the top bar and footer already declare as their own min-block-size, with file:line pointers to both, instead of an opaque 191px constant. Doesn't remove the underlying coupling (still no ResizeObserver / shared token), but a future edit to either component's minimum height now has a documented, unit-matching term to update instead of an unexplained magic number. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -45,19 +45,6 @@ export const BURNED_ROAD_LOCAL_CONTENT: LocalLocationContent = {
|
||||
yPercent: 33,
|
||||
enabled: true,
|
||||
},
|
||||
{
|
||||
key: 'wounded-scout',
|
||||
title: 'Verwundeter Kundschafter',
|
||||
actionLabel: 'Sprechen',
|
||||
type: 'NPC',
|
||||
iconKey: 'speak',
|
||||
xPercent: 17,
|
||||
yPercent: 62,
|
||||
enabled: true,
|
||||
resultTitle: 'Verwundeter Kundschafter',
|
||||
resultText:
|
||||
'„Die Straße ist nicht mehr sicher. Die Plünderer kommen aus Richtung des alten Wachtpostens. Wenn du weitergehst, halte die Augen offen."',
|
||||
},
|
||||
{
|
||||
key: 'inspect-tracks',
|
||||
title: 'Verdächtige Spuren',
|
||||
@@ -84,6 +71,19 @@ export const BURNED_ROAD_LOCAL_CONTENT: LocalLocationContent = {
|
||||
resultText:
|
||||
'Der Wagen wurde gründlich geplündert. Zwischen verbrannten Brettern findest du nur leere Kisten und Spuren eines hastigen Aufbruchs.',
|
||||
},
|
||||
{
|
||||
key: 'wounded-scout',
|
||||
title: 'Verwundeter Kundschafter',
|
||||
actionLabel: 'Sprechen',
|
||||
type: 'NPC',
|
||||
iconKey: 'speak',
|
||||
xPercent: 17,
|
||||
yPercent: 62,
|
||||
enabled: true,
|
||||
resultTitle: 'Verwundeter Kundschafter',
|
||||
resultText:
|
||||
'„Die Straße ist nicht mehr sicher. Die Plünderer kommen aus Richtung des alten Wachtpostens. Wenn du weitergehst, halte die Augen offen."',
|
||||
},
|
||||
],
|
||||
localPrimaryActions: [
|
||||
{
|
||||
|
||||
@@ -262,15 +262,15 @@ describe('seedVisibleVerticalSlice', () => {
|
||||
}[];
|
||||
expect(pointsOfInterest.map((poi) => poi.key)).toEqual([
|
||||
'hunt-area',
|
||||
'wounded-scout',
|
||||
'inspect-tracks',
|
||||
'search-abandoned-wagon',
|
||||
'wounded-scout',
|
||||
]);
|
||||
expect(pointsOfInterest.map((poi) => poi.type)).toEqual([
|
||||
'HUNT',
|
||||
'NPC',
|
||||
'INVESTIGATE',
|
||||
'SEARCH',
|
||||
'NPC',
|
||||
]);
|
||||
|
||||
const primaryActions = burnedRoad.localPrimaryActions as {
|
||||
|
||||
Reference in New Issue
Block a user