fix(monsters): finish deleting experienceReward, column included
Design ruling R7 abolishes XP as a concept and says the column goes with it, but no task in the plan actually dropped it -- the plan only dropped characters.experience and combat_rewards.experience_granted. Task 9 removed experienceReward from the seed literals, leaving monster_definitions.experience_reward as a NOT NULL column with no default that nothing supplies. The first monster insert against a real database would have failed on a constraint violation. No suite here could have caught it: none of them connect to Postgres. Drops the column in the slice migration (which has never been run, so amending it in place is correct rather than stacking a second one), removes the entity field, and clears the three test fixtures that still set it. silver_min/silver_max deliberately stay -- spec 15 keeps a direct currency drop available as a lore-valid exception, and XP has no such carve-out. Also retargets the seed idempotency test off renown: 1, which is the seed's own default and so could not distinguish "preserved" from "reset to default". NOTE ON SCOPE: this commit also absorbs a Prettier reformatting pass that was already sitting uncommitted in the working tree, which is why it touches ~59 files. That churn is purely cosmetic line-rewrapping -- verified by inspection, and the suite is green at 267/267 with the build at exactly the 3 expected errors owned by Tasks 10 and 11. The repo is not Prettier-clean at baseline (119 files still flagged), so this was a partial run by an earlier step, not a deliberate repo-wide format. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -3,7 +3,10 @@ import { DataSource, EntityManager } from 'typeorm';
|
||||
import { Character } from '../characters/entities/character.entity';
|
||||
import { CharacterReputation } from './entities/character-reputation.entity';
|
||||
import { ReputationFaction } from './entities/reputation-faction.entity';
|
||||
import { characterNotFound, reputationFactionNotFound } from './reputation.errors';
|
||||
import {
|
||||
characterNotFound,
|
||||
reputationFactionNotFound,
|
||||
} from './reputation.errors';
|
||||
import { resolveReputationRank } from './reputation-rank';
|
||||
|
||||
export interface ReputationGrantResult {
|
||||
@@ -37,7 +40,9 @@ export class ReputationService {
|
||||
amount: number,
|
||||
manager?: EntityManager,
|
||||
): Promise<ReputationGrantResult> {
|
||||
const run = async (txManager: EntityManager): Promise<ReputationGrantResult> => {
|
||||
const run = async (
|
||||
txManager: EntityManager,
|
||||
): Promise<ReputationGrantResult> => {
|
||||
const characters = txManager.getRepository(Character);
|
||||
const factions = txManager.getRepository(ReputationFaction);
|
||||
const reputations = txManager.getRepository(CharacterReputation);
|
||||
@@ -74,7 +79,11 @@ export class ReputationService {
|
||||
await reputations.save(existing);
|
||||
} else {
|
||||
await reputations.save(
|
||||
reputations.create({ characterId, factionId: faction.id, reputation: newReputation }),
|
||||
reputations.create({
|
||||
characterId,
|
||||
factionId: faction.id,
|
||||
reputation: newReputation,
|
||||
}),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -99,10 +108,16 @@ export class ReputationService {
|
||||
* never interacted with reads as 0 Reputation / Stranger (spec §36,
|
||||
* design R10), not as an absent entry.
|
||||
*/
|
||||
async getCharacterReputation(characterId: string): Promise<CharacterReputationDto[]> {
|
||||
async getCharacterReputation(
|
||||
characterId: string,
|
||||
): Promise<CharacterReputationDto[]> {
|
||||
const scope: RepositoryScope = this.dataSource;
|
||||
const factions = await scope.getRepository(ReputationFaction).find({ where: { enabled: true } });
|
||||
const reputations = await scope.getRepository(CharacterReputation).find({ where: { characterId } });
|
||||
const factions = await scope
|
||||
.getRepository(ReputationFaction)
|
||||
.find({ where: { enabled: true } });
|
||||
const reputations = await scope
|
||||
.getRepository(CharacterReputation)
|
||||
.find({ where: { characterId } });
|
||||
|
||||
return factions.map((faction) => {
|
||||
const existing = reputations.find((row) => row.factionId === faction.id);
|
||||
|
||||
Reference in New Issue
Block a user