From b5bcd50dcdcb76c8412f5dc11d98140d9100684a Mon Sep 17 00:00:00 2001 From: Bastian Wagner Date: Fri, 21 Aug 2026 18:06:38 +0200 Subject: [PATCH] docs(web): correct the victory-refresh comment about what combat grants The comment claimed the server had granted "silver and renown" on a combat win. It does not: grantVictoryRewards adds silver and item drops, and nothing in apps/api/src/combat or apps/api/src/rewards touches renown at all. Renown comes from milestones only. Introduced when I committed Task 15's staged work after its agent was cut off mid-step; caught by the task review. Co-Authored-By: Claude Opus 5 --- .../app/features/combat/combat-page/combat-page.component.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/web/src/app/features/combat/combat-page/combat-page.component.ts b/apps/web/src/app/features/combat/combat-page/combat-page.component.ts index 66e7907..a30fe7c 100644 --- a/apps/web/src/app/features/combat/combat-page/combat-page.component.ts +++ b/apps/web/src/app/features/combat/combat-page/combat-page.component.ts @@ -105,8 +105,9 @@ export class CombatPageComponent implements OnInit { } if (after.status === 'WON') { - // The server already granted silver and renown; pull the authoritative - // character so the HUD matches (spec §35). + // The server already granted silver and any item drops; pull the + // authoritative character so the HUD matches (spec §35). Renown is + // not granted here -- it comes from milestones only. void this.worldStore.refreshCharacter(); }