bastian/ashen-realms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(web): use the German "Ansehen" for Renown in the Topbar

Browse Source 
The Topbar rendered the English word "Renown", replacing the German
"Stufe" it showed before. That contradicted the slice's own global
constraint that all user-facing copy is German, and it was the single
English string in a component visible on every screen -- next to
"Silber", "Lebenspunkte" and "Charakterdaten werden geladen".

This was a spec defect, not an implementation one: the design doc and
the task brief both prescribed "Renown" literally. The document's
working language leaked into a copy-locked line.

"Ruf" is not available as the German term -- this project already uses
it for the separate per-faction Reputation system, and the two are
deliberately kept distinct. "Ansehen" (standing/prestige) is unclaimed
and matches the spec's own definition of Renown as the character's
overall significance in the world.

Records the decision as R17 in the design doc so later Renown UI does
not reintroduce the English term, and renames the now-inaccurate
top-bar__level class to top-bar__renown (nothing else referenced it).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Bastian Wagner
2026-08-21 14:59:01 +02:00
parent cea1d2ecf5
commit df4c0c5527
4 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/superpowers/specs/2026-08-21-renown-reputation-foundation-design.md
View File

@@ -259,7 +259,9 @@ POST /api/turn-ins → { turnInKey: string; quantity: number } → TurnInR
## 11. Frontend changes
- **`game-api.models.ts`**: `CharacterResponse.level`/`.experience` → `.renown: number`. New `ReputationEntry`/`TurnInResult` interfaces mirroring the API DTOs. `InventoryItem.item.type` (if surfaced) reflects the new `ItemType` values; `requiredLevel` removed if present anywhere in the web model.
- **Topbar** (`top-bar.component.html`): `Stufe {{ character.level }}` → `Renown {{ character.renown }}`; `data-top-bar-experience` XP block deleted entirely.
- **Topbar** (`top-bar.component.html`): `Stufe {{ character.level }}` → `Ansehen {{ character.renown }}`; `data-top-bar-experience` XP block deleted entirely. The wrapping span's class is renamed `top-bar__level` → `top-bar__renown` to match.
**R17 — the German display term for Renown is "Ansehen", not "Renown" and not "Ruf".** Earlier drafts of this line said `Renown`, which contradicted the global constraint that all user-facing copy is German — the working language of this document leaking into copy-locked text. `Ruf` is unavailable: it is the German term this project already uses for the separate per-faction *Reputation* system (see the reputation display's `factionName + ' Ruf'`), and the two systems are deliberately kept distinct. `Ansehen` (standing/prestige) is unclaimed and matches §2.2's definition of Renown as the character's overall significance in the world.
- **Combat victory screen** (`combat-page.component.html`/`.spec.ts`): `data-reward-experience` block and its three referencing tests deleted (R16); `rewards.silver` block stays.
- **New `ReputationDisplayComponent`** (`apps/web/src/app/shared/reputation-display/`): standalone component, input `entry: ReputationEntry`, renders faction name, rank label, `current / nextThreshold` (or just current if `nextThreshold` is null, at Esteemed), a progress bar. Built and unit-tested; not wired into any page (R15).