From dfa62fd152e7e678c12b7b62702651ce0a22e157 Mon Sep 17 00:00:00 2001 From: Bastian Wagner Date: Sat, 22 Aug 2026 09:17:23 +0200 Subject: [PATCH] fix: translate the last five German fixture strings found by the final review's re-review Fixes 5 residual findings from the re-review of Playable Slice 0.6.6's whole-branch review: two twice-hit spec files still carried invented or seeded German fixture values (reputation-display faction name, inventory-detail-panel item description and item name), a world store fixture still used a German location description, and a dev comment in reputation-content.ts referenced a faction name that no longer exists in the code. All are literal string substitutions using already-translated canon English text; no keys, ids, or logic changed. --- apps/api/src/database/seeds/reputation-content.ts | 6 +++--- .../inventory/inventory-detail-panel.component.spec.ts | 6 +++--- apps/web/src/app/features/world/world.store.spec.ts | 3 ++- .../reputation-display/reputation-display.component.spec.ts | 4 ++-- 4 files changed, 10 insertions(+), 9 deletions(-) diff --git a/apps/api/src/database/seeds/reputation-content.ts b/apps/api/src/database/seeds/reputation-content.ts index 3fc1ee8..10d5b68 100644 --- a/apps/api/src/database/seeds/reputation-content.ts +++ b/apps/api/src/database/seeds/reputation-content.ts @@ -9,9 +9,9 @@ export interface SeedReputationFaction { enabled: boolean; } -// Only Grenzwacht is seeded and usable in Slice 0.6.5 (spec §8). Dämmerjäger -// ('dusk-hunters') and Letzte Wacht ('last-watch') are future-region keys, -// intentionally not seeded yet. +// Only the Border Watch (Grenzwacht in the spec) is seeded and usable in +// Slice 0.6.5 (spec §8). Dämmerjäger ('dusk-hunters') and Letzte Wacht +// ('last-watch') are future-region keys, intentionally not seeded yet. export const REPUTATION_FACTIONS: SeedReputationFaction[] = [ { id: BORDER_GUARD_FACTION_ID, diff --git a/apps/web/src/app/features/inventory/inventory-detail-panel.component.spec.ts b/apps/web/src/app/features/inventory/inventory-detail-panel.component.spec.ts index 34eb29f..2bc606c 100644 --- a/apps/web/src/app/features/inventory/inventory-detail-panel.component.spec.ts +++ b/apps/web/src/app/features/inventory/inventory-detail-panel.component.spec.ts @@ -45,7 +45,7 @@ const ashPelt: InventoryItem = { equipped: false, item: { key: 'ash-pelt', - name: 'Aschenfell', + name: 'Ash Pelt', description: 'Item description.', rarity: 'COMMON', equipmentSlot: null, @@ -99,12 +99,12 @@ describe('InventoryDetailPanelComponent', () => { const fixture = await setup({ item: { ...banditBlade, - item: { ...banditBlade.item, description: 'Eine grob gezahnte Klinge.' }, + item: { ...banditBlade.item, description: 'A roughly serrated blade, forged for quick raids.' }, }, }); expect((fixture.nativeElement as HTMLElement).textContent).toContain( - 'Eine grob gezahnte Klinge.', + 'A roughly serrated blade, forged for quick raids.', ); }); diff --git a/apps/web/src/app/features/world/world.store.spec.ts b/apps/web/src/app/features/world/world.store.spec.ts index 714a1c3..87d111d 100644 --- a/apps/web/src/app/features/world/world.store.spec.ts +++ b/apps/web/src/app/features/world/world.store.spec.ts @@ -27,7 +27,8 @@ const character: CharacterResponse = { const currentLocation = southGateFixture({ id: 'origin-id', name: 'South Gate', - description: 'Der Ausgang zur Wildnis.', + description: + "At the black South Gate, Graufurt's protection ends. Beyond the watch-fires begins the silent expanse of the Ashen Fields.", dangerLevel: 1, connections: [ { diff --git a/apps/web/src/app/shared/reputation-display/reputation-display.component.spec.ts b/apps/web/src/app/shared/reputation-display/reputation-display.component.spec.ts index 80ffac8..0ffe955 100644 --- a/apps/web/src/app/shared/reputation-display/reputation-display.component.spec.ts +++ b/apps/web/src/app/shared/reputation-display/reputation-display.component.spec.ts @@ -76,7 +76,7 @@ describe('ReputationDisplayComponent', () => { it('renders a sensible zero-reputation row for a faction never interacted with', async () => { const fixture = await setup({ factionKey: 'silent-order', - factionName: 'Der Stille Orden', + factionName: 'The Silent Order', reputation: 0, rank: 'STRANGER', rankLabel: 'Stranger', @@ -84,7 +84,7 @@ describe('ReputationDisplayComponent', () => { }); const element = fixture.nativeElement as HTMLElement; - expect(element.textContent).toContain('Der Stille Orden'); + expect(element.textContent).toContain('The Silent Order'); expect(element.textContent).toContain('Stranger'); expect(element.textContent).toContain('0');