apps/api runs ts-jest with isolatedModules: true, which skips cross-file
type checking. Task 3 proved the gap concretely: the suite reported
233/234 green while npm run build reported 21 real errors across 6
files. Every full-suite step now runs test && build, with a Global
Constraints note explaining why the build half is not redundant.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1. inventory.service.ts (API production code) surfaces requiredLevel in
its response DTO. Task 3 deletes the entity column, so this would
fail to compile and keep shipping a dead field. No task covered it:
Task 10 swept only test fixtures, Task 12 only the web model. Folded
into Task 10 as a new Step 0.
2. No web-side sweep task existed. Task 12's model changes break
CharacterResponse/InventoryItem fixtures in app.spec.ts,
world.store.spec.ts, and inventory.store.spec.ts, none of which
Tasks 13-16 touch. Added Task 17 mirroring Task 10's sweep rule.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
16 tasks: pure-function power curve and rank resolver, one migration
covering Character/ItemDefinition/ItemType/CombatReward changes plus
five new tables, three new domain services (Renown, Reputation,
TurnIn), XP removal from the combat reward pipeline, requiredLevel
gate removal, seed content for Grenzwacht/Räuberabzeichen/turn-ins,
a fixture sweep, and the web-side Renown/Reputation surfaces.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Records every judgment call the spec left open — Renown/Reputation
data model, service signatures, migration strategy, combat reward
pipeline changes, and API/frontend surface — as an explicit, auditable
ruling with its cost if wrong, per instruction to implement this slice
without confirmation stops.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
hunt-page.component.spec.ts and resume-combat.spec.ts each build a
direct type-annotated Combat literal that the new required
CombatPlayer/CombatMonster fields would break at compile time.
Verified with an isolated tsc --strict probe, and used the same probe
to confirm the combat.service.spec.ts `as Combat` fixtures do NOT
break (structural widening through the type assertion), so no change
needed there.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Covers the engine rewrite for HEAVY_STRIKE/SHIELD_BASH/DEFEND/POTION,
deterministic monster telegraphing/interrupt, the DB migration for the
new combat event types, and the web action bar + telegraph banner.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
