log

tests/sync/test_manager.py

@@ -4,7 +4,7 @@ import pytest
 from sqlalchemy import select
 
 from app.db.models import ActivityStatus, HealthState, SyncRun, SyncRunStatus, SyncUser
-from app.db.repositories import UserRepository
+from app.db.repositories import SystemLogRepository, UserRepository
 from app.garmin.uploader import UploadResult
 from app.mywhoosh.client import MyWhooshDeviceConflictError
 from app.mywhoosh.models import MyWhooshActivity
@@ -305,6 +305,44 @@ async def test_does_not_renotify_for_unresolved_unchanged_reason(session_factory
     assert len(notifier.sent) == 1
 
 
+class FailingNotifier:
+    def send(self, *, to_address: str, subject: str, body: str) -> None:
+        raise RuntimeError("SMTP connection refused")
+
+
+@pytest.mark.asyncio
+async def test_email_send_failure_is_recorded_in_system_log_and_does_not_break_sync(
+    session_factory, cipher, settings
+) -> None:
+    with session_factory() as session:
+        user = _create_user(session, cipher)
+        user.notify_email_enabled = True
+        user.notification_email = "alerts@example.com"
+        session.commit()
+        user_id = user.id
+
+    manager = SyncManager(
+        session_factory=session_factory,
+        credential_cipher=cipher,
+        settings=settings,
+        mywhoosh_factory=lambda token_store: DeviceConflictMyWhooshClient(),
+        garmin_factory=lambda email, password, tokenstore: FakeGarminUploader(),
+        fit_converter=FakeFitConverter(),
+        notifier=FailingNotifier(),
+    )
+
+    outcome = await manager.sync_user(user_id)
+    assert outcome.status == "failed"
+
+    with session_factory() as session:
+        entries = SystemLogRepository(session).list_recent()
+        assert len(entries) == 1
+        assert entries[0].source == "email_notification"
+        assert entries[0].user_id == user_id
+        assert "SMTP connection refused" in entries[0].message
+        assert "alerts@example.com" in entries[0].message
+
+
 @pytest.mark.asyncio
 async def test_mfa_code_reaches_real_garmin_uploader_via_sync_manager(
     session_factory, cipher, settings, seeded_user: SyncUser