bastian/ashen-realms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: translate the last five German fixture strings found by the final review's re-review

Browse Source 
Fixes 5 residual findings from the re-review of Playable Slice 0.6.6's
whole-branch review: two twice-hit spec files still carried invented
or seeded German fixture values (reputation-display faction name,
inventory-detail-panel item description and item name), a world store
fixture still used a German location description, and a dev comment
in reputation-content.ts referenced a faction name that no longer
exists in the code. All are literal string substitutions using
already-translated canon English text; no keys, ids, or logic changed.
This commit is contained in:
Bastian Wagner
2026-08-22 09:17:23 +02:00
parent 8418a93329
commit dfa62fd152
4 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/api/src/database/seeds/reputation-content.ts
View File

@@ -9,9 +9,9 @@ export interface SeedReputationFaction {
enabled: boolean;
}
// Only Grenzwacht is seeded and usable in Slice 0.6.5 (spec §8). Dämmerjäger
// ('dusk-hunters') and Letzte Wacht ('last-watch') are future-region keys,
// intentionally not seeded yet.
// Only the Border Watch (Grenzwacht in the spec) is seeded and usable in
// Slice 0.6.5 (spec §8). Dämmerjäger ('dusk-hunters') and Letzte Wacht
// ('last-watch') are future-region keys, intentionally not seeded yet.
export const REPUTATION_FACTIONS: SeedReputationFaction[] = [
{
id: BORDER_GUARD_FACTION_ID,

6
apps/web/src/app/features/inventory/inventory-detail-panel.component.spec.ts
View File

@@ -45,7 +45,7 @@ const ashPelt: InventoryItem = {
equipped: false,
item: {
key: 'ash-pelt',
name: 'Aschenfell',
name: 'Ash Pelt',
description: 'Item description.',
rarity: 'COMMON',
equipmentSlot: null,
@@ -99,12 +99,12 @@ describe('InventoryDetailPanelComponent', () => {
const fixture = await setup({
item: {
...banditBlade,
item: { ...banditBlade.item, description: 'Eine grob gezahnte Klinge.' },
item: { ...banditBlade.item, description: 'A roughly serrated blade, forged for quick raids.' },
},
});
expect((fixture.nativeElement as HTMLElement).textContent).toContain(
'Eine grob gezahnte Klinge.',
'A roughly serrated blade, forged for quick raids.',
);
});

3
apps/web/src/app/features/world/world.store.spec.ts
View File

@@ -27,7 +27,8 @@ const character: CharacterResponse = {
const currentLocation = southGateFixture({
id: 'origin-id',
name: 'South Gate',
description: 'Der Ausgang zur Wildnis.',
description:
"At the black South Gate, Graufurt's protection ends. Beyond the watch-fires begins the silent expanse of the Ashen Fields.",
dangerLevel: 1,
connections: [
{

4
apps/web/src/app/shared/reputation-display/reputation-display.component.spec.ts
View File

@@ -76,7 +76,7 @@ describe('ReputationDisplayComponent', () => {
it('renders a sensible zero-reputation row for a faction never interacted with', async () => {
const fixture = await setup({
factionKey: 'silent-order',
factionName: 'Der Stille Orden',
factionName: 'The Silent Order',
reputation: 0,
rank: 'STRANGER',
rankLabel: 'Stranger',
@@ -84,7 +84,7 @@ describe('ReputationDisplayComponent', () => {
});
const element = fixture.nativeElement as HTMLElement;
expect(element.textContent).toContain('Der Stille Orden');
expect(element.textContent).toContain('The Silent Order');
expect(element.textContent).toContain('Stranger');
expect(element.textContent).toContain('0');